Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Properly define dependencies on system extensions #2328

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee
Copy link
Contributor Author

I'm not quite sure which of these extensions are hard dependencies, which should be suggestions, and which should be development dependencies. I'll appreciate your thoughts on this, @georgringer!

@georgringer
Copy link
Owner

Looks good, what about adding scheduler to suggest as well?

@oliverklee oliverklee changed the title [TASK] Properly defined dependencies on system extensions [TASK] Properly define dependencies on system extensions Jan 17, 2024
@oliverklee oliverklee marked this pull request as draft January 17, 2024 12:52
@oliverklee
Copy link
Contributor Author

oliverklee commented Jan 17, 2024

Marking as draft. I'd like #2315 and #2329 to get merged first.

@oliverklee
Copy link
Contributor Author

what about adding scheduler to suggest as well?

Done.

@oliverklee oliverklee marked this pull request as ready for review January 19, 2024 09:34
@georgringer georgringer merged commit b5da14a into georgringer:main Jan 21, 2024
17 checks passed
@oliverklee oliverklee deleted the task/system-exts branch January 21, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants