Skip to content

Commit

Permalink
Apply feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
theroggy committed Dec 26, 2024
1 parent acf53d2 commit 93aa064
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions pyogrio/_io.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -2748,8 +2748,8 @@ cdef create_fields_from_arrow_schema(
# column. When a column with the appropriate name is present in the data,
# GDAL will automatically use it for the FID. Reference:
# https://gdal.org/en/stable/tutorials/vector_api_tut.html#writing-to-ogr-using-the-arrow-c-data-interface
# Hence, the column should not be created as an ordinary field well.
# Doing so anyway additionally triggers a bug in GDAL < 3.10.1:
# Hence, the column should not be created as an ordinary field as well.
# Doing so triggers a bug in GDAL < 3.10.1:
# https://github.com/OSGeo/gdal/issues/11527#issuecomment-2556092722
fid_column = get_string(OGR_L_GetFIDColumn(destLayer))

Expand All @@ -2766,8 +2766,8 @@ cdef create_fields_from_arrow_schema(
continue

# Don't create property for column that will already be used as FID
# Note: it seems that GDAL initially checks the FID column
# case-sensitive, but then falls back to case-insensitive matching via
# Note: it seems that GDAL initially uses a case-sensitive check of the
# FID column, but then falls back to case-insensitive matching via
# the "ordinary" field being added. So, the check here needs to be
# case-sensitive so the column is still added as regular column if the
# casing isn't matched, otherwise the column is simply "lost".
Expand Down

0 comments on commit 93aa064

Please sign in to comment.