Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeometryStreamBuilder #965

Merged
merged 3 commits into from
Dec 23, 2024
Merged

GeometryStreamBuilder #965

merged 3 commits into from
Dec 23, 2024

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Dec 23, 2024

Change list

  • Instead of using really complex code to figure out which underlying array to push each individual xy call to, we use an underlying GeoWriter to collect each geometry into a scratch buffer, and then push that geometry using our existing push_geometry APIs. This simplifies the code a lot.
  • It may have a negative performance impact because we're allocating extra heap buffers for the small vecs. In the future, if we want to optimize this, we may want to create a version of geo-types that uses something like bumpalo

Closes #365

@kylebarron kylebarron merged commit 8af6586 into main Dec 23, 2024
21 checks passed
@kylebarron kylebarron deleted the kyle/geometry-stream-builder2 branch December 23, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement GeometryCollectionStreamBuilder for building array from geozero
1 participant