Skip to content

Commit

Permalink
libgcc/whole-archive cleanup
Browse files Browse the repository at this point in the history
* remove unnecessary 'whole-archive' entries from qmake.tcl and cmake.tcl
* remove unnecessary and unused globals of 'ldlibs_so'

issue #68
  • Loading branch information
ssumpf authored and jschlatow committed Nov 24, 2023
1 parent 089740b commit f131153
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 7 deletions.
4 changes: 2 additions & 2 deletions share/goa/lib/build/autoconf.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ proc create_or_update_build_dir { } {
mirror_source_dir_to_build_dir

global build_dir cross_dev_prefix project_name project_dir
global cppflags cflags cxxflags ldflags ldlibs_common ldlibs_exe ldlibs_so
global cppflags cflags cxxflags ldflags ldlibs_common ldlibs_exe

# invoke configure script only once
if {[file exists [file join $build_dir config.status]]} {
Expand Down Expand Up @@ -74,7 +74,7 @@ proc create_or_update_build_dir { } {

proc build { } {

global build_dir verbose project_name jobs project_dir ldlibs_common ldlibs_exe ldlibs_so
global build_dir verbose project_name jobs project_dir ldlibs_common ldlibs_exe

set cmd { }

Expand Down
2 changes: 1 addition & 1 deletion share/goa/lib/build/cargo.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ proc generate_static_stubs { libs } {
proc build { } {

global build_dir cross_dev_prefix verbose debug project_name jobs project_dir
global cppflags cflags cxxflags ldflags ldlibs_common ldlibs_exe ldlibs_so lib_src
global cppflags cflags cxxflags ldflags ldlibs_common ldlibs_exe lib_src
global cc_march

set rustflags { }
Expand Down
3 changes: 0 additions & 3 deletions share/goa/lib/build/cmake.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ proc create_or_update_build_dir { } {
set orig_pwd [pwd]
cd $build_dir

lappend ldflags "-Wl,--whole-archive"
lappend ldlibs_common -Wl,--whole-archive -lgcc -Wl,--no-whole-archive

set ::env(LDFLAGS) "$ldflags $ldlibs_common $ldlibs_exe"

set cmd { }
Expand Down
2 changes: 1 addition & 1 deletion share/goa/lib/build/make.tcl
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
proc _make_cmd { } {
global build_dir cross_dev_prefix verbose jobs project_dir
global cppflags cflags cxxflags ldflags ldlibs_common ldlibs_exe ldlibs_so lib_src
global cppflags cflags cxxflags ldflags ldlibs_common ldlibs_exe lib_src

set cmd { }

Expand Down

0 comments on commit f131153

Please sign in to comment.