fix, number review changes getting updated geneontology/noctua-annota…

…tion-review#30
geneontology · Jan 14, 2021 · b165ea7 · b165ea7
1 parent 5991af3
commit b165ea7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/app/main/apps/noctua-search/noctua-search.component.html b/src/app/main/apps/noctua-search/noctua-search.component.html
@@ -110,8 +110,8 @@ <h4 *ngIf="!noctuaUserService.user">
             </button>
             <div class="noc-line" fxFlex="80px" [ngClass]="{'noc-visited': noctuaSearchMenuService.reviewLevel>1}">
             </div>
-            <button mat-stroked-button (click)="selectMiddlePanel(MiddlePanel.reviewChanges); reviewChanges()" class=""
-              color="" [ngClass]="{'noc-active': noctuaSearchMenuService.selectedMiddlePanel === MiddlePanel.reviewChanges,
+            <button mat-stroked-button (click)="selectMiddlePanel(MiddlePanel.reviewChanges)" class="" color=""
+              [ngClass]="{'noc-active': noctuaSearchMenuService.selectedMiddlePanel === MiddlePanel.reviewChanges,
             'noc-visited': noctuaSearchMenuService.reviewLevel>2}">
               <div class="noc-title">Checkout</div> <br>
               <div class="noc-description">Review and submit changes</div>
@@ -138,4 +138,4 @@ <h4 *ngIf="!noctuaUserService.user">
 
     </mat-drawer>
   </mat-drawer-container>
-</div>
+</div>
diff --git a/src/app/main/apps/noctua-search/noctua-search.component.ts b/src/app/main/apps/noctua-search/noctua-search.component.ts
@@ -160,27 +160,24 @@ export class NoctuaSearchComponent implements OnInit, AfterViewInit, OnDestroy {
   }
 
   selectMiddlePanel(panel) {
+    const self = this;
     this.noctuaSearchMenuService.selectMiddlePanel(panel);
 
     switch (panel) {
       case MiddlePanel.cams:
         this.noctuaSearchMenuService.selectLeftPanel(LeftPanel.filter);
         break;
       case MiddlePanel.camsReview:
+        self.camsService.reviewChanges();
         this.noctuaSearchMenuService.selectLeftPanel(LeftPanel.artBasket);
         break;
       case MiddlePanel.reviewChanges:
+        self.camsService.reviewChanges();
         this.noctuaSearchMenuService.selectLeftPanel(LeftPanel.artBasket);
         break;
     }
   }
 
-  reviewChanges() {
-    const self = this;
-
-    self.camsService.reviewChanges();
-    self.noctuaSearchMenuService.selectMiddlePanel(MiddlePanel.reviewChanges);
-  }
 
   openRightDrawer(panel) {
     this.noctuaSearchMenuService.selectRightPanel(panel);