Feat/add sortable name to file tree #807
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Change information
Currently the file tree component sorts based on the file/folder name.
However, this means that a file with name
The file
will come before thana file
, since"T" < "a"
.This PR adds an optional
sortableName
field, which allows us to pass in a lowercase name without modifying how the name is ultimately rendered.An alternative approach would be to just do
.toLowerCase()
within the sorting functions, but this would change existing behavior, and some people may want default sorting to sort uppercase before lowercase.Another approach would be for the file tree to be unopinionated about sort order (e.g. pass in a
shouldSort?:boolean
flag or similar.First contribution, open to critiques!