Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added withModId function #83

Merged
merged 2 commits into from
Oct 9, 2024
Merged

added withModId function #83

merged 2 commits into from
Oct 9, 2024

Conversation

Smef
Copy link
Member

@Smef Smef commented Oct 8, 2024

There was no way to submit the Mod ID with an eloquent model, so this has been adde in as a withModId() function to call before calling save()

@Smef Smef requested a review from likeadeckofcards October 8, 2024 17:35
@Smef Smef self-assigned this Oct 8, 2024
Copy link
Member

@likeadeckofcards likeadeckofcards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is starting to look good but I don't think it will have the desired functionality at the moment

src/Database/Eloquent/FMEloquentBuilder.php Outdated Show resolved Hide resolved
src/Database/Eloquent/FMModel.php Outdated Show resolved Hide resolved
src/Database/Eloquent/FMModel.php Show resolved Hide resolved
@Smef Smef requested a review from likeadeckofcards October 8, 2024 18:53
@Smef Smef merged commit 0a7519a into 2.x Oct 9, 2024
1 check passed
@Smef Smef deleted the feature/add-modId branch October 9, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants