Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make expression evaluation lazy #847

Closed
wants to merge 1 commit into from
Closed

Make expression evaluation lazy #847

wants to merge 1 commit into from

Conversation

ISSOtm
Copy link
Member

@ISSOtm ISSOtm commented Apr 19, 2021 •
edited
Loading

Closes #663.

TODO:

  • Make constant expression evaluation not produce error messages, but only RPN error bytes
  • Adapt the rest of the code
  • Write rpn_Reduce, which attempts to compute an expression's value, and actually produces the error messages if not
  • Bonus: reuse rpn_Reduce in RGBLINK?

@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM labels Apr 19, 2021
@Rangi42 Rangi42 added this to the v0.5.1 milestone Apr 20, 2021
@ISSOtm ISSOtm force-pushed the lazy-eval branch 2 times, most recently from a335d91 to d74bf08 Compare April 24, 2021 11:53
@ISSOtm
Copy link
Member Author

ISSOtm commented Apr 25, 2021

This is actually hell to implement. What I've done so far lays some groundwork, but it's lacking.

The most difficult part is actually being able to defer error reporting! This is much, much more involved than it seems.

@Rangi42 Rangi42 modified the milestones: v0.5.1, v0.6.0 Apr 25, 2021
Rangi42 added a commit to Rangi42/rgbds that referenced this pull request Apr 25, 2021
@Rangi42
Port some cleanup from PR gbdev#847
482cd36 
- Update some whitespace formatting
- Factor out some functions
- Free data after outputting to an object file
Rangi42 added a commit to Rangi42/rgbds that referenced this pull request Apr 25, 2021
@Rangi42
Port some cleanup from PR gbdev#847
d172155 
- Update some whitespace formatting
- Factor out some functions
- Free data after outputting to an object file
Rangi42 added a commit that referenced this pull request Apr 28, 2021
@Rangi42
Port some cleanup from PR #847
bba5321 
- Update some whitespace formatting
- Factor out some functions
- Free data after outputting to an object file
@Rangi42 Rangi42 added the WIP This PR is a work in progress label May 5, 2021
@Rangi42 Rangi42 removed this from the v0.10.0 milestone Aug 6, 2024
@ISSOtm ISSOtm closed this Aug 30, 2024
@ISSOtm ISSOtm deleted the lazy-eval branch August 30, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM WIP This PR is a work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow lazy evaluation of some expressions
2 participants
@ISSOtm @Rangi42