Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same FP limits for TrackedVehicle to avoid self-moving (backport #2651) #2695

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 9, 2024

🦟 Bug fix

Fixes #2506

Summary

Using the same constants for checking against zero here to significantly reduce cases when system behaves in unexpected way.
Still for a solid solution we should consider a refactoring a whole algorithm.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #2651 done by [Mergify](https://mergify.com).

Signed-off-by: Maksim Derbasov <[email protected]>
(cherry picked from commit 6f7d21f)
@mergify mergify bot requested a review from mjcarroll as a code owner December 9, 2024 21:24
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Dec 9, 2024
@azeey azeey merged commit ebf0758 into gz-sim8 Dec 9, 2024
10 checks passed
@azeey azeey deleted the mergify/bp/gz-sim8/pr-2651 branch December 9, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants