Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New system plugin called DriveToPoseController #2679

Open
wants to merge 13 commits into
base: gz-sim9
Choose a base branch
from

Conversation

sauk2
Copy link
Contributor

@sauk2 sauk2 commented Nov 17, 2024

🎉 New feature

Closes #2379

Summary

This PR adds a new system plugin to gz-sim called DriveToPoseController. This is not a standalone plugin and requires other systems plugins (DiffDrive and OdometryPublisher) to function.

This controller receives a target pose in the Gazebo coordinate system on /cmd_pose topic and calculates and publishes a command velocity on /cmd_vel topic to move the robot towards the target. This plugin contains separate linear and angular proportional controllers with adjustable gains. The user can also specify an allowable deviation from the goal pose in the form of linear and angular deviations. Upon reaching the goal pose, the controller publishes an acknowledgement on /reached_pose topic to indicate the end of the navigation operation.

The plugin needs to be attached to a model entity as in the SDF as follows,

    <model>
        <!-- Model information --> 
 
        <!-- Required to define DiffDrive and OdometryPublisher -->

        <!-- DriveToPoseController --> 
        <plugin
          filename="gz-sim-drive-to-pose-controller-system"
          name="gz::sim::systems::DriveToPoseController">
          <linear_p_gain>1.0</linear_p_gain>
          <angular_p_gain>2.0</angular_p_gain>
          <linear_deviation>0.1</linear_deviation>
          <angular_deviation>0.05</angular_deviation>
        </plugin>
    </model>

It has the following parameter tags,

  • <linear_p_gain> - (Optional) Proportional gain for the linear velocity controller. Default: 1.0
  • <angular_p_gain> - (Optional) Proportional gain for the angular velocity controller. Default: 2.0
  • <linear_deviation> - (Optional) Allowable linear deviation (in meters) from the desired coordinate. Default: 0.1
  • <angular_deviation> - (Optional) Allowable angular deviation (in radians) from the desired orientation. Default: 0.05

The following example warehouse world can be found at src/gz-sim/examples/worlds/drive_to_pose_controller.sdf with an AMR spawned at its start position.

image

image

Test it

The integration test for this plugin can be run using the following command,

  colcon test --event-handlers console_direct+ --merge-install \
    --packages-select gz-sim9 --ctest-args -R drive_to_pose_controller

Use the following steps to test the functionality in the warehouse world by sending the robot to four different poses,

  1. Launch the following world,
  gz sim drive_to_pose_controller.sdf

NOTE: The world opens in a paused state so make sure to unpause before sending the pose commands

  1. Send the robot to the first pose in the warehouse, [x, y, orientation] = [1.78, -9.4, -3.14]
  gz topic -t "/model/DeliveryBot/cmd_pose" -m gz.msgs.Pose_V \
    -p "pose:[{position: {x: 1.78, y: -9.4, z: 0.0}, orientation: {x: 0.0, y: 0.0, z: -0.99, w: 0.0}}]"
  1. Send the robot to the second pose, [x, y, orientation] = [-3.75, -9.4, 1.57]
  gz topic -t "/model/DeliveryBot/cmd_pose" -m gz.msgs.Pose_V \
    -p "pose:[{position: {x: -3.75, y: -9.4, z: 0.0}, orientation: {x: 0.0, y: 0.0, z: 0.707, w: 0.707}}]"
  1. Send the robot to its third pose, [x, y, orientation] = [-3.75, 9.18, 3.14]
  gz topic -t "/model/DeliveryBot/cmd_pose" -m gz.msgs.Pose_V \
    -p "pose:[{position: {x: -3.75, y: 9.18, z: 0.0}, orientation: {x: 0.0, y: 0.0, z: 0.99, w: 0.0}}]"
  1. Send the robot to its final pose, [x, y, orientation] = [-5.9, 9.18, 3.14]
  gz topic -t "/model/DeliveryBot/cmd_pose" -m gz.msgs.Pose_V \
    -p "pose:[{position: {x: -5.9, y: 9.18, z: 0.0}, orientation: {x: 0.0, y: 0.0, z: 0.99, w: 0.0}}]"

The entire operation is shown in the following video,

drive_to_pose_controller_test.mp4

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]>
@sauk2 sauk2 requested a review from mjcarroll as a code owner November 17, 2024 09:39
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Nov 17, 2024
Signed-off-by: Saurabh Kamat <[email protected]>
}

// Get linear P gain if available
if (_sdf->HasElement("linear_p_gain"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add here some gzdbg or gzwarm to show which are the values of the gains

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I am now printing all the parameter values through gzdbg

test/integration/drive_to_pose_controller_system.cc Outdated Show resolved Hide resolved
test/integration/drive_to_pose_controller_system.cc Outdated Show resolved Hide resolved
test/integration/drive_to_pose_controller_system.cc Outdated Show resolved Hide resolved
test/integration/drive_to_pose_controller_system.cc Outdated Show resolved Hide resolved

using namespace gz;
using namespace sim;
using namespace std::chrono_literals;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this used? and if this is used somewhere, you should include <chrono>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the feedback! I have added the necessary includes

This is used in the following line where I am using the ns operator

server.SetUpdatePeriod(0ns);

Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Here is some feedback.

topicNamespace + "/cmd_pose", &DriveToPoseControllerPrivate::OnCmdPose,
this->dataPtr.get());

this->dataPtr->node.Subscribe(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing for subscribers, we can detect if there are publishers. If no publishers inform the user that we need to load the correct set of plugins. (We could also automatically load them if that is something you are willing to look into).

Copy link
Contributor Author

@sauk2 sauk2 Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arjo129 Thanks for all the feedback! It makes perfect sense to warn users if no publishers or subscribers are found. I have made the changes to check for the availability of necessary publishers and subscribers and warn users to load the required plugins.

However, I agree it would be a good idea to load the plugins ourselves if they are found to be missing, and I would be happy to implement this. If you have any references for this that would be great help. Also, do you want this change to be a part of this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of the top of my head there is a service to load plugins:

Since the system is running inside the server it may be worth exposing an API for doing this via the ECS instead of relying on gz-transport for later.

@sauk2 sauk2 requested review from ahcorde and arjo129 November 21, 2024 11:29
Signed-off-by: Saurabh Kamat <[email protected]>
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, otherwise look good to me

test/integration/drive_to_pose_controller_system.cc Outdated Show resolved Hide resolved
test/integration/drive_to_pose_controller_system.cc Outdated Show resolved Hide resolved
test/integration/drive_to_pose_controller_system.cc Outdated Show resolved Hide resolved
test/integration/drive_to_pose_controller_system.cc Outdated Show resolved Hide resolved
test/integration/drive_to_pose_controller_system.cc Outdated Show resolved Hide resolved
examples/worlds/drive_to_pose_controller.sdf Outdated Show resolved Hide resolved
examples/worlds/drive_to_pose_controller.sdf Outdated Show resolved Hide resolved
examples/worlds/drive_to_pose_controller.sdf Outdated Show resolved Hide resolved
examples/worlds/drive_to_pose_controller.sdf Outdated Show resolved Hide resolved
@sauk2
Copy link
Contributor Author

sauk2 commented Dec 17, 2024

Some minor changes, otherwise look good to me

Thank you for the feedback! I have made the requested changes.

@sauk2 sauk2 requested a review from ahcorde December 17, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Proposal] Drive to point/configuration controller plugin for wheeled vehicles
3 participants