Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuring global illumination GUI plugin parameters #2594

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 5, 2024

🦟 Bug fix

Summary

The Global illumination GUI plugin's parameters specified through SDF are currently parsed by the plugin but they have no effect. This PR fixes the issue for both plugins (Vct and CiVct).

To test, you can run this world:

gi_gui.sdf
<?xml version="1.0" encoding="UTF-8"?>

<sdf version="1.10">
  <world name="default">
    <gui fullscreen="0">
      <plugin filename="GlobalIlluminationVct" name="GI">
        <gz-gui>
          <property type="string" key="state">docked_collapsed</property>
        </gz-gui>
        <enabled>true</enabled>
        <highQuality>false</highQuality>
        <resolution>32 32 32</resolution>
        <octantCount>2 2 2</octantCount>
        <conserveMemory>false</conserveMemory>
        <thinWallCounter>1.1</thinWallCounter>
        <anisotropic>false</anisotropic>
        <bounceCount>7</bounceCount>
      </plugin>
    </gui>

    <model name="ground_plane">
      <static>true</static>
      <link name="link">
        <collision name="collision">
          <geometry>
            <plane>
              <normal>0 0 1</normal>
              <size>100 100</size>
            </plane>
          </geometry>
        </collision>
        <visual name="visual">
          <geometry>
            <plane>
              <normal>0 0 1</normal>
              <size>100 100</size>
            </plane>
          </geometry>
        </visual>
      </link>
    </model>
  </world>
</sdf>

and verify that the GI properties displayed in the GUI match those specified in SDF:

gi_parameters

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner September 5, 2024 01:46
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 5, 2024
@iche033 iche033 marked this pull request as draft September 5, 2024 01:54
@iche033 iche033 marked this pull request as ready for review September 5, 2024 02:06
@iche033 iche033 merged commit f8f8a80 into gz-sim9 Sep 5, 2024
10 checks passed
@iche033 iche033 deleted the gi_vct_qml branch September 5, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants