Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xml and image in create maritime vehicle tutorial #2592

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

alexandrosnic
Copy link
Contributor

@alexandrosnic alexandrosnic commented Sep 4, 2024

🦟 Bug fix

Fixes #

Summary

Replaced single quotes '' to double quotes "" in XML (my XML parser did not accept the single quotes), and fixed the path to the image in order to be displayed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 4, 2024
tutorials/create_vehicle.md Outdated Show resolved Hide resolved
Signed-off-by: Alexandros Nicolaou <[email protected]>
@iche033 iche033 merged commit 96e1b03 into gazebosim:gz-sim9 Sep 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants