Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse voxel resolution SDF param when decomposing meshes #2445

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 14, 2024

🎉 New feature

Summary

Similar to gazebosim/gz-physics#655 but applies the changes here for dartsim.

Test it

The same changes are also available in #2352. With that PR, you can visualize the decomposed mesh. Here's an example with the cordless drill model

Left: voxel resolution 80000
Right: voxel resolution 800000 (10x)

voxel_resolution

This mesh is relatively simple so the difference is small but on right drill with higher voxel resolution, the collision wraps more tightly to the actual mesh.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 merged commit cd9a855 into gz-sim8 Jun 17, 2024
8 checks passed
@iche033 iche033 deleted the voxel_resolution branch June 17, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants