-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for no gravity link #2398
Conversation
Can you signoff your commits following the instructions here: https://github.com/gazebosim/gz-sim/pull/2398/checks?check_run_id=24713135239 On a side note if you need to achieve the same effect immediately: I achieve similar results using the |
Signed-off-by: youhy <[email protected]>
72af63d
to
c71a3b3
Compare
Signed-off-by: youhy <[email protected]>
I signed off with a new GPG key and added the key to Gtihub after I made the PR. So apparently DCO doesn't like that. Now it's fixed.
Thanks. I'll try that. |
@osrf-jenkins run tests please |
Signed-off-by: Ian Chen <[email protected]>
made some minor changes in 72b8f3c - simplified gravity component data check, and updated style and indentation. |
@ahcorde friendly ping to see if you're ok with the new changes and also merging this PR? |
🎉 New feature
Original issue: #504
A feature I find very useful when I use Gazebo Classic but surprisingly unavailable in Ignition.
I'm targeting Gazebo Fortress because I need this feature for my projects on Fortress. Might need some back/forward porting.
Changes in other repo:
gz-physics: gazebosim/gz-physics#633
sdformat: gazebosim/sdformat#1410
Summary
Add parsing and support for no gravity link when using DartSim engine
Implementation for other physics engines should be easy if they have link no gravity API.
Test it
Spawn the following entity to gazebo.
The way I do this is to add
<gravity>false</gravity>
togz-sim/examples/standalone/entity_creation
's inline sdf and run the example.The black sphere has link gravity disabled and the cube is spawned with GUI and has gravity by default.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.