Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example world for DopplerVelocityLogSystem #2373

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Added example world for DopplerVelocityLogSystem #2373

merged 6 commits into from
Apr 18, 2024

Conversation

sauk2
Copy link
Contributor

@sauk2 sauk2 commented Apr 17, 2024

🎉 New feature

Closes #2344

Summary

The examples/worlds directory does not contain any example world for DopplerVelocityLogSystem plugin. This PR adds the following:

  • Example world based on test/worlds/flat_seabed.sdf but with a SceneBroadcaster.
  • README.md in test/worlds directory to inform users not to use those world files.

More information can be found in Issue #2344 and PR #2346.

Test it

This world can be tested (after building and sourcing the workspace) using the following command

  gz sim flat_seabed.sdf

Checklist

  • Signed all commits for DCO
  • Added example and/or tutorial
  • Updated documentation
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@sauk2 sauk2 requested a review from mjcarroll as a code owner April 17, 2024 13:30
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 17, 2024
@sauk2 sauk2 mentioned this pull request Apr 17, 2024
Closed
3 tasks
@sauk2
Removed extra line at the end
2bb5394 
Signed-off-by: Saurabh Kamat <[email protected]>
@arjo129 arjo129 changed the title Added exampe world for DopplerVelocityLogSystem Added example world for DopplerVelocityLogSystem Apr 18, 2024
arjo129
arjo129 reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@arjo129 arjo129 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I just have a few knits with this before we merge this.

examples/worlds/flat_seabed.sdf Outdated Show resolved Hide resolved
examples/worlds/flat_seabed.sdf Outdated Show resolved Hide resolved
examples/worlds/flat_seabed.sdf Outdated Show resolved Hide resolved
@sauk2 sauk2 requested a review from arjo129 April 18, 2024 05:21
arjo129
arjo129 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@arjo129 arjo129 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested it just now. Looks good to me.

@arjo129 arjo129 enabled auto-merge (squash) April 18, 2024 06:12
@arjo129 arjo129 disabled auto-merge April 18, 2024 06:12
@arjo129 arjo129 enabled auto-merge (squash) April 18, 2024 06:13
@arjo129 arjo129 merged commit dfcfd00 into gazebosim:gz-sim8 Apr 18, 2024
8 checks passed
@sauk2 sauk2 deleted the feat/underwater-example branch April 18, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjo129 arjo129 arjo129 approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run test worlds for underwater simulation
2 participants
@sauk2 @arjo129