Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thruster test: remove unnecessary sleep #2357

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Apr 4, 2024

🦟 Bug fix

Fixes #

Summary

I'm not why this sleep was here in the first place. But it does not seem to be needed. The only thing it does is slow down our tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Im not why this sleep was her in the first place. But it does not seem
to be needed.

Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 requested a review from mjcarroll as a code owner April 4, 2024 05:58
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 4, 2024
@arjo129
Copy link
Contributor Author

arjo129 commented Apr 4, 2024

@osrf-jenkins run tests please

@scpeters scpeters changed the title Remove unnecessary sleep thruster test: remove unnecessary sleep Apr 4, 2024
@arjo129 arjo129 merged commit 6884e66 into gz-sim8 Apr 4, 2024
6 of 9 checks passed
@arjo129 arjo129 deleted the arjo/fix/not_sure_why_theres_a_sleep branch April 4, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants