Fixed undefined behavior in thruster.cc #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Gaurav Kumar <[email protected]>
Co-authored-by: Arjo Chakravarty <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Gaurav Kumar <[email protected]>
Co-authored-by: Arjo Chakravarty <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
Until SystemManager has the ability to unload system plugins, plugins require an explicit check of the validity of the entities used in the Update methods. Such a check was missing in OdometryPublisher, which led to non-critical but annoying errors in the console. --------- Signed-off-by: Anton Bogdanov <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
…sim#2324) Signed-off-by: Gabriel Arjones <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
* Fix wget in maritime tutorials. Signed-off-by: Carlos Agüero <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
This is a fix to the error seen in Ackermann Steering's <steering_only> mode. The steps to reproduce this error are described in issue gazebosim#2314. Signed-off-by: Saurabh Kamat <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Saurabh Kamat <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
Signed-off-by: Gaurav Kumar <[email protected]>
Co-authored-by: Arjo Chakravarty <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
|
@arjo129 I hope this is cleaner ! |
arjo129
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2291
Summary