Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish step size in world stats topic #2340

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Publish step size in world stats topic #2340

merged 2 commits into from
Mar 22, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 21, 2024

🎉 New feature

Summary

The step_size field in WorldStatistics msg is currently not populated / published in the /stats topic. This PR populates the field in a way that conforms to the msg documentation: /// \brief Iteration step size. It's zero when paused.

Test it

# run gz sim
gz sim -v 4 -r shapes.sdf

...

# echo the stats topic
gz topic -e -t /world/shapes/stats

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner March 21, 2024 18:42
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 21, 2024
src/SimulationRunner.cc Outdated Show resolved Hide resolved
src/SimulationRunner.cc Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 merged commit 5faaf5e into gz-sim8 Mar 22, 2024
5 of 8 checks passed
@iche033 iche033 deleted the stats_step_size branch March 22, 2024 17:10
GauravKumar9920 pushed a commit to GauravKumar9920/gz-sim that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants