Fix INTEGRATION_save_world on windows
#2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading the rendering pipeline multiple times in a test doesn't seem to work well. This removes the Sensors system from the `non_rendering_sensors.sdf` file so that Ogre2 and the whole rendering pipeline is only loaded once. Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-sim8 #2300 +/- ##
========================================
Coverage 65.92% 65.92%
========================================
Files 327 327
Lines 31286 31286
========================================
Hits 20626 20626
Misses 10660 10660 ☔ View full report in Codecov by Sentry. |
mjcarroll
approved these changes
Jan 29, 2024
iche033
approved these changes
Jan 29, 2024
|
I rerun the windows job 4 times and each time there was a new test failure, but not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2177
Summary
Loading the rendering pipeline multiple times in a test doesn't seem to work well. This removes the Sensors system from the
non_rendering_sensors.sdffile so that Ogre2 and the whole rendering pipeline is only loaded once.CI Builds:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.