Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check SKIP_PYBIND11 for python bindings #2298

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Part of #2249, uses osrf/homebrew-simulation#2543 via ci_matching_branch/

Summary

This is a minor change to the cmake logic for enabling python bindings and is used as an opportunity to test whether the changes in osrf/homebrew-simulation#2543 will help fix #2249.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from mjcarroll as a code owner January 24, 2024 19:15
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a267a68) 65.76% compared to head (96062aa) 65.75%.
Report is 1 commits behind head on gz-sim8.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim8    #2298      +/-   ##
===========================================
- Coverage    65.76%   65.75%   -0.02%     
===========================================
  Files          327      327              
  Lines        31233    31233              
===========================================
- Hits         20541    20537       -4     
- Misses       10692    10696       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scpeters
Copy link
Member Author

I think osrf/homebrew-simulation#2543 is only a partial fix; it ensures that our binary bottles are all using the same version of python, but for these CI jobs, we need to also pass -DPython3_EXECUTABLE=$(which python3); I'll try an update to release-tools as well

@scpeters
Copy link
Member Author

I think osrf/homebrew-simulation#2543 is only a partial fix; it ensures that our binary bottles are all using the same version of python, but for these CI jobs, we need to also pass -DPython3_EXECUTABLE=$(which python3); I'll try an update to release-tools as well

I think gazebo-tooling/release-tools#1110 may be enough

@scpeters
Copy link
Member Author

@osrf-jenkins run tests please

@scpeters
Copy link
Member Author

the macOS python tests are passing in CI!

@scpeters scpeters merged commit f28f679 into gz-sim8 Jan 31, 2024
9 of 11 checks passed
@scpeters scpeters deleted the ci_matching_branch/harmonic_python_fix branch January 31, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Python tests fail in CI on macOS
2 participants