Light entity match SDF boolean for UserCommands. #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will rebase this soon as #2286 gets merged in. |
bperseghetti
changed the title
Allow for setting all matching light entities by setting <set_all_light_entities> boolean in usercommands plugin's sdf. Signed-off-by: Benjamin Perseghetti <[email protected]>
bperseghetti
force-pushed
the
pr-lights-match-all
branch
from
a070d6d to
52a74ac
Compare
Signed-off-by: Benjamin Perseghetti <[email protected]>
|
Test just added, should have full coverage now. |
|
@osrf-jenkins run tests please |
Signed-off-by: Benjamin Perseghetti <[email protected]>
bperseghetti
force-pushed
the
pr-lights-match-all
branch
from
af05521 to
4f6bad5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## gz-sim8 #2295 +/- ##
===========================================
+ Coverage 65.92% 65.95% +0.02%
===========================================
Files 327 327
Lines 31286 31323 +37
===========================================
+ Hits 20626 20658 +32
- Misses 10660 10665 +5 ☔ View full report in Codecov by Sentry. |
ahcorde
reviewed
Jan 30, 2024
Signed-off-by: Benjamin Perseghetti <[email protected]>
mjcarroll
reviewed
Jan 31, 2024
Signed-off-by: Benjamin Perseghetti <[email protected]>
mjcarroll
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Unable to set multiple matching light entities like what is done in MaterialColor.
Adding an SDF boolean element
<set_all_light_entities>to usercommands plugin allows for controlling matching light entities.Waiting first on merge of #2286 for MaterialColor change.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.