Allow using plugin file names and environment variables compatible with Garden and later #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arden and later Signed-off-by: Addisu Z. Taddese <[email protected]>
mjcarroll
reviewed
Jan 4, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
iche033
reviewed
Jan 5, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
the |
iche033
approved these changes
Jan 6, 2024
Also use the user-commands system for testing instead of physics since the physics system does not load properly on windows CI. Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
mjcarroll
reviewed
Jan 12, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
CI is good. Windows warnings are preexisting, so I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Allows using gz-* in plugin filenames (eg.
<plugin filename="gz-sim-physics-system" name="gz::sim::systems::Physics"/>) and usingGZ_*environment variables in Fortress. This is meant to help users (especially ROS users) maintain SDF files and launch files that work in both Fortress and Garden/Harmonic.Test it
I've added tests that exercise:
gz-sim-*filenames in<plugin>tags (src/SystemLoader_TEST.cc)GZ_SIM_SYSTEM_PLUGIN_PATH(src/SystemLoader_TEST.cc)GZ_SIM_RESOURCE_PATH(src/Server.cc)GZ_SIM_SERVER_CONFIG_PATH(src/ServerConfig_TEST.cc)I have not added a test for
GZ_SIM_RENDER_ENGINE_PATHsince I couldn't find a test forIGN_GAZEBO_RENDER_ENGINE_PATHand I don't think it's a commonly used environment variable.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.