-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ogre 1.x custom shaders support #908
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-rendering7 #908 +/- ##
=================================================
+ Coverage 77.23% 77.63% +0.40%
=================================================
Files 170 170
Lines 14724 14724
=================================================
+ Hits 11372 11431 +59
+ Misses 3352 3293 -59
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor style issues. is it possible to add a test ?
Signed-off-by: Ian Chen <[email protected]>
yep, will add one |
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment
Signed-off-by: Ian Chen <[email protected]>
🎉 New feature
Related gazebosim/gz-sim#2002 (comment)
Summary
Extended to support features needed to render waves:
Code is ported from the ogre2 implementation
Test it
Build and run the waves example
Sky is not supported yet in ogre 1.x so you'll only see waves in this demo:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.