Better approach to use std::variant #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Derbasov <[email protected]>
ntfshard
force-pushed
the
better_variant_using
branch
from
0bdee12 to
4a655ff
Compare
azeey
requested changes
Dec 17, 2024
There was a problem hiding this comment.
Thanks for the contribution!! I agree we shouldn't use exceptions for flow control in C++. I'm concerned that std::get might still throw an exception, but I can't think of a better way. std::get_if is possible, but the resulting code would be a lot more verbose I think.
I do have one comment about the use of static.
Signed-off-by: Maksim Derbasov <[email protected]>
azeey
approved these changes
Dec 18, 2024
|
@Mergifyio backport gz-rendering8 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Better approach to use std::variant Signed-off-by: Maksim Derbasov <[email protected]> * Iteration Signed-off-by: Maksim Derbasov <[email protected]> --------- Signed-off-by: Maksim Derbasov <[email protected]> (cherry picked from commit 7765666)
8 tasks
iche033
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Better approach to use std::variant Signed-off-by: Maksim Derbasov <[email protected]> * Iteration Signed-off-by: Maksim Derbasov <[email protected]> --------- Signed-off-by: Maksim Derbasov <[email protected]> (cherry picked from commit 7765666)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
Using exception for a flow control is not a very good approach in a different points of view, like from a code structure, from a performance perspective (https://godbolt.org/z/s883vGr9f)
I'd propose to use std::holds_alternative as a more simple way to improve this part of code.
Also improved some typos
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.