Add a flexible mechanism to combine user and default plugins #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
iche033
reviewed
Aug 1, 2024
| @@ -98,6 +98,8 @@ namespace gz::gui | |||
| /// \sa InitializeDialogs | |||
| public: bool LoadConfig(const std::string &_path); | |||
|
|
|||
| public: bool LoadWindowConfig(const tinyxml2::XMLElement &_window); | |||
There was a problem hiding this comment.
add doxygen comments for the new functions?
src/Application.cc
Outdated
| @@ -524,6 +506,37 @@ std::string Application::DefaultConfigPath() | |||
| return this->dataPtr->defaultConfigPath; | |||
| } | |||
|
|
|||
| std::string Application::ResolveConfigFile(const std::string &_path) | |||
There was a problem hiding this comment.
add separation line /////////////////////////////////////////////////
azeey
added
the
Breaking change
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
iche033
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes gazebosim/gz-sim#796
Summary
This works in conjunction with gazebosim/gz-sim#2497 to allow specifying plugins without replacing the default list of plugins.
Test it
Try examples in gazebosim/gz-sim#2497
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.