feat(gatsby-transformer-sqip): migrate to async version of SQIP #33824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
axe312ger
commented
Nov 2, 2021
axe312ger
commented
Nov 2, 2021
LekoArts
changed the title
LekoArts
added
topic: plugins
|
This failing e2e test is so weird. Feels like a race condition to me. Something in between the downloading of the source image and the processing of it. Works locally, of course :D |
axe312ger
force-pushed
the
refactor/migrate-to-sqip-v1
branch
3 times, most recently
from
1b43c51 to
04b6c22
Compare
miraclecra
previously approved these changes
Nov 23, 2021
axe312ger
force-pushed
the
refactor/migrate-to-sqip-v1
branch
from
04b6c22 to
baafea7
Compare
axe312ger
added
the
status: needs core review
axe312ger
force-pushed
the
refactor/migrate-to-sqip-v1
branch
2 times, most recently
from
f2cec92 to
1dc00ff
Compare
axe312ger
force-pushed
the
refactor/migrate-to-sqip-v1
branch
from
1dc00ff to
b0b9c8b
Compare
axe312ger
force-pushed
the
refactor/migrate-to-sqip-v1
branch
from
b0b9c8b to
056ac38
Compare
axe312ger
force-pushed
the
refactor/migrate-to-sqip-v1
branch
from
056ac38 to
c0302d1
Compare
|
closing in favor of #37919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally the new async version of SQIP is ready for Gatsby.
This PR just updates the lib and migrates the code to ensure it is non-breaking change.
The new version of SQIP supports new SVG transformers, so a follow up PR will implement these.
It also creates smaller result SVGs.
Learn more about the upcoming version of SQIP: https://github.com/axe312ger/sqip && axe312ger/sqip#90