Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tryke #304

Closed
wants to merge 5 commits into from
Closed

Tryke #304

wants to merge 5 commits into from

Conversation

vallsjm
Copy link

@vallsjm vallsjm commented Jun 18, 2014

This is a new structure suggestion.

Now we have a JSON file with all data, "manifest.json" contain all boxes.

@JonTheNiceGuy
Copy link
Collaborator

We have a similar proposal in #29 by @jney, progressed in #271 by @fgrehm. I think I'd like sign-off from @garethr before we approach either of these two. Given #29 and #271 have some history, I suspect that would be a better approach to follow, but... as I said, I'd like guidance from others before I consider merging. Also, it'd break the other 10 open PRs, so we'd need to back-port any fixes in those.

@vallsjm
Copy link
Author

vallsjm commented Jun 19, 2014

You're right.

In my proposal it is considered important to structure the data a little with a JSON. That would allow more powerful filters, exports, etc...

@JonTheNiceGuy JonTheNiceGuy mentioned this pull request Nov 27, 2014
@JonTheNiceGuy
Copy link
Collaborator

I'm not going to merge this commit. We already have a new structure to move towards in #29 / #271. Once that has been implemented, maybe we can look to replace the front with Angular, but right now we're not ready to take that step.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants