Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated breakpoint import description, removed old "deprecated" import #201

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

thexmanxyz
Copy link
Contributor

@thexmanxyz thexmanxyz commented Jan 25, 2020

@mahagr @RyanMPierson I noticed that under 04./10. there is a wrong description of the import procedure for using breakpoints within SCSS. Additionally there seems to be a leftover from the previous import procedure within the example code. Hence I rewrote the paragraph before the example SCSS to reflect what's really happening. We are not using @import "nucleus/mixins/breakpoints"; any more within the example so we should not describe the old routine here but rather describe what's happening when using @import "dependencies".

Additionally in the example code below (the last line) there was still the old import lurking around. Which probably was overseen during the docs update. So the description and the below example now clearly reflects what should be done when someone wants to use the breakpoint mixin without ambiguity.

@thexmanxyz thexmanxyz requested a review from simmonsr January 25, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants