[24.1] Determine expression tool output extension when input terminal #19364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19245 by waiting for the dataset to become terminal if it's a expression.json dataset that we infer the output datatype from.
A slightly better implementation could look at the tool outputs when we generate the command line, which is when we're going to submit and have the terminal datasets ... ?
How to test the changes?
(Select all options that apply)
License