unit tests failing due to concurrent access of the mock file system. Make it more reliable #320
Conversation
…Make it more reliable Signed-off-by: Mike Cobbett <[email protected]>
|
Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-320-gtgc4-r-6bprl for details. If you are unable to do so, please contact a member of the Galasa team. |
|
Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-320-4nmtv for details. If you are unable to do so, please contact a member of the Galasa team. |
|
Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-320-7xt8c for details. If you are unable to do so, please contact a member of the Galasa team. |
|
Build successful |
Signed-off-by: Mike Cobbett [email protected]
Why ?
See issue: Unstable test in CLI causes occasional build failure. MockFS concurrency. #2094
Unit test failed occasionally because of timing/race. 2 threads concurrently accessing/updating the node map inside the mockFileSystem.
Fixed by adding mutexes around all the external calls to the file system, so the internals only run single-threaded. Rather clumsy, but simple and good enough for unit tests.