Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add output_file_name parameter. #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kosyloa
Copy link

@kosyloa kosyloa commented Oct 8, 2022

Hi, Gabriel.
I started use your NISQA code.
First of all: thanks a lot for your big work.

I use predict in batch mode with saving results in the same directory.
And I faced with problem: lib uses the same name of file for all evaluation. of course, i can save in different folders.

But I added parameter for output file name. To avoid backward compatibility problems: it is parameter with default value(previous file name which used in your code)

nisqa/NISQA_model.py Outdated Show resolved Hide resolved
@kosyloa
Copy link
Author

kosyloa commented Oct 14, 2022

changed

@gabrielmittag
Copy link
Owner

Oh looks like you missed the quotes around 'output_file_name'

@kosyloa
Copy link
Author

kosyloa commented Oct 16, 2022

Oh looks like you missed the quotes around 'output_file_name'

Fixed. Thx

Hadlay-Zhang pushed a commit to Hadlay-Zhang/NISQA that referenced this pull request Sep 8, 2023
Added new descriptive tools for Speech Quality Prediction:
- Mean and Standard Deviation calculations of the predictions
- BarCharts and LineCharts of the predictions

This change helps provide better assistance especially for Speech Quality Testing,
e.x. repeated averaging of results for the same test sample in practical audio testing scenarios.
Also, output name of csv is added just like gabrielmittag#30.
Hadlay-Zhang pushed a commit to Hadlay-Zhang/NISQA that referenced this pull request Sep 8, 2023
Added descriptive tools for Speech Quality Prediction:
- Mean and Standard Deviation of the results
- BarChart and LineChart of the results
This change helps provide better assistance in Speech Quality Prediction, especially for
repeated averaging of results of the same test sample in practical Audio Testing Scenarios.
Also, output name of CSV is added just like gabrielmittag#30.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants