Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new on background colors #4959

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

toaster
Copy link
Member

@toaster toaster commented Jun 22, 2024

Description:

This PR introduces four new “on” colors:

  • primaryOnBackground
  • errorOnBackground
  • successOnBackground
  • warningOnBackground

This enables us to use a more specific color for text and icons on the default background color (or similar).
Thus, we can change the “normal” primary, error etc. colors to have a good contrast with the normal foreground color (or similar).

This PR does not change any color values, yet.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@Jacalz Jacalz changed the base branch from master to develop June 22, 2024 20:08
@coveralls
Copy link

Coverage Status

coverage: 66.025% (+0.5%) from 65.491%
when pulling 7641a44 on toaster:feature/on_background_colors
into d8e9fe0 on fyne-io:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants