Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dapi): add data api endpoint version to connection info #372

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

MichaelL79
Copy link
Contributor

Added the target version to the ConnectionInfo object. Hope, this is the correct location

Copy link
Owner

@fuzzzerd fuzzzerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This looks pretty good. I had a few comments, please take a look and let me know what you think.

tests/FMData.Rest.Tests/GeneralTests.cs Outdated Show resolved Hide resolved
src/FMData.Rest/FileMakerRestClient.cs Outdated Show resolved Hide resolved
src/FMData.Rest/FileMakerRestClient.cs Outdated Show resolved Hide resolved
@MichaelL79
Copy link
Contributor Author

Just implemented your suggestions

@fuzzzerd fuzzzerd changed the title Data api endpoint version feat(dapi): add data api endpoint version to connection info Dec 9, 2024
Copy link
Owner

@fuzzzerd fuzzzerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for your contribution!

@fuzzzerd fuzzzerd merged commit 325bccb into fuzzzerd:master Dec 9, 2024
5 checks passed
@fuzzzerd fuzzzerd linked an issue Dec 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to select the DataAPI version
2 participants