Ability to override Content-Type header for responses #119
+25
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smellman
added a commit
to smellman/react-native-static-server
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GCDWebServerprovided the method that allows overriding the MIME types butreact-native-static-serverdidn’t expose that capability, I added the optionalmimeTypeOverridesargument to give the ability to override response’s Content-Type header.Motivation and Context
When I tried to use this to set up our local server, it failed to set the correct
Content-Typeheader for responses returning XML files. It setsapplication/octet-streaminstead ofapplication/xmlasXMLHttpRequestexpects.The root cause is that
GCDWebServersets the response’sContent-Typeheader toapplication/octet-streamfor all file types, except for a few well-known ones such as HTML or CSS. Therefore, I implemented a simple change as described above to set the correct Content-Type header for responses.