Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getElementFocusListener method, keysCallback and keysBackspaceCallback #78

Closed
wants to merge 4 commits into from

Conversation

rpbarreira
Copy link

@rpbarreira rpbarreira commented Mar 31, 2023

Added getElementFocusListener method to get the focus event listener of an element by its id
Added keysCallback to be able to call it every time any key is clicked
Added keysBackspaceCallback to be able to call it every time the backspace key is clicked

Issues: #75 #77 #79

Added keysCallback to be able to call it every time any key is clicked
Added getElementFocusListener method to get the focus event listener of an element by its id
@rpbarreira rpbarreira changed the title Added keysCallback Added getElementFocusListener method and keysCallback Mar 31, 2023
Added keysBackspaceCallback to be able to call it every time the backspace key is clicked
@rpbarreira rpbarreira changed the title Added getElementFocusListener method and keysCallback Added getElementFocusListener method, keysCallback and keysBackspaceCallback Mar 31, 2023
@furcan
Copy link
Owner

furcan commented Mar 31, 2023

Hello,
Thank you for your contribution.

You can please propose your changes only with
https://github.com/furcan/KioskBoard/blob/main/src/kioskboard.js
Then I will take a look.

All the other files will be generated by the build script and do not require any actions on your end.

Thanks,
Furkan

@rpbarreira
Copy link
Author

Hello Furcan,

Ok, I will close this PR and open a new one that way.

Thanks for this valuable project!
Best regards,
Rui Barreira

@rpbarreira rpbarreira closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants