De-prioritize intWitnessAs
implicit on Scala 3
#1317
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are already several specialized instances e.g.
intWitnessAsLong
. These should be higher priority than this generic instance that relies onNumeric
.Annoyingly, starting in Scala 3.6 the implicit resolution changes cause the following warning. Fixing the prioritization should address the warning.
Alternatively, perhaps this implicit was ported in error. The equivalent on the Scala 2 side is for
Nat
, which isn't available for Scala 3, so perhaps was swapped forInt
?refined/modules/core/shared/src/main/scala-3.0-/eu/timepit/refined/internal/WitnessAs.scala
Lines 31 to 36 in 20df7cc