Use static interfaces, remove AdHoc Encoding. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusty
force-pushed
the
gus/static-interface
branch
from
d0a3b42 to
5cc8202
Compare
| @@ -577,7 +579,9 @@ module TestInterfaces = | |||
| Assert.StringContains ("", "brand", stjCarJson) | |||
| Assert.StringContains ("", "brand", stjGCarJson) | |||
|
|
|||
| do ICodecInterface<IVehicle>.RegisterCodec<AdHocEncoding, Truck> Truck.ObjCodec | |||
| do ICodecInterface<IVehicle>.RegisterCodec<Fleece.SystemJson.Encoding , Truck> Truck.ObjCodec | |||
|
My feeling is that you could register multiple for the subset that you care about, why ad hoc encoding might be less useful in reality. |
|
There was surprisingly few changes that I had to do in order to get it working with a sample project: |
|
Well it seems only one in the code: |
|
I'll try it then 👍 |
gusty
force-pushed
the
master
branch
2 times, most recently
from
c8ccdf4 to
d98b168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will take advantage of static interfaces, which is the natural way of conding the
IEncodinginterface.The question is what do we do with codec for interfaces which uses Ad-Hoc Encoding which relied in an instance to call the interface methods.