Adjust parse / tryParse #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusty
force-pushed
the
gus/parse-tryparse
branch
from
c88073d to
503ce33
Compare
gusty
force-pushed
the
gus/parse-tryparse
branch
from
503ce33 to
c35f111
Compare
gusty
force-pushed
the
gus/parse-tryparse
branch
from
d9e34f0 to
b036b9d
Compare
wallymathieu
reviewed
Oct 2, 2023
src/FSharpPlus/Control/Converter.fs
Outdated
| @@ -139,6 +163,15 @@ type Parse = | |||
| | _ -> invalidArg "value" ("Requested value '" + x + "' was not found.") | |||
| ) : 'enum | |||
|
|
|||
| #if !FABLE_COMPILER | |||
| static member Parse (_: DateTime , _: Parse) = fun (x:string) -> | |||
| try DateTime.ParseExact (x, [|"yyyy-MM-ddTHH:mm:ss.fffZ"; "yyyy-MM-ddTHH:mm:ssZ"|], null, DateTimeStyles.RoundtripKind) | |||
There was a problem hiding this comment.
Could the TryParse implementation be used instead?
wallymathieu
approved these changes
Oct 2, 2023
gusty
force-pushed
the
gus/parse-tryparse
branch
from
b797b7a to
61959f2
Compare
wallymathieu
approved these changes
Oct 3, 2023
gusty
force-pushed
the
master
branch
2 times, most recently
from
c718153 to
3962979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions
parseandtryParseshould behave the same, the only difference should be in throwing or returningNone.