Remove deleted argument to VisitSubkernelsAndSelf #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dotnet/interactive#3563, the
VisitSubkernelsAndSelf
method (insrc/Microsoft.DotNet.Interactive/KernelExtensions.cs
) was updated to remove therecursive
argument, which breaks XPlot:This should fix the binding, though I haven't built or tested anything yet.
Two possible issues:
Microsoft.DotNet.Interactive
because they had a default value for the deleted argument, but binaries will need to run against compatible versions because the signature of the call is explicit in the IL. Specifically, new XPlot won't work with old Interactive.VisitSubkernelsAndSelf
is only non-recursive, so this is a behavior change from before (which passedtrue
).