Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect width of APCu Hit/Miss bar #1283

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

lukasbableck
Copy link
Contributor

Description

The width of the APCu Miss bar in the Hit/Miss graph on the APCu info page is calculated incorrectly, resulting in both bars always being the same width. This PR fixes that issue.

Before:
image

After:
image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  1. Make change
  2. See bars with correct width

Test Configuration:

  • Distribution: Debian 12
  • Webserver: Nginx
  • PHP: 8.3 FPM
  • etc.etc.:

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@d00p d00p merged commit 228eb24 into froxlor:main Oct 1, 2024
9 checks passed
@lukasbableck lukasbableck deleted the patch-1 branch October 1, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants