-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more fritz devices and tftp #29
base: master
Are you sure you want to change the base?
Conversation
Use pathlib for path operations Minor fixes in logic
Fix ssh options for OpenSSH 9
Disregards any operations not involved in serving a file.
User must be allowed to add/delete ip configuration (sudoers file or execute as sudo/root)
better error handling remove ip on error basic netsh support
* FR 1200 needs uboot too * flash sysupgrade for other routers too
56a73b3
to
8bfe454
Compare
8bfe454
to
f8943a7
Compare
bea55de
to
4b1565c
Compare
* add support for FB 3390 * improve transfer visualization through tftp * isort, black, typing, remove unused imports
4b1565c
to
56a9b4c
Compare
@herbetom could you please look into this and give feedback? I think it would be cool to have an easier flashing method for the 7520 in the upstream fritzflash project :) |
@maurerle I've merged some "docs stuff" in the past, but thats about it. Most of the code is from @blocktrron. I appreciate you trying to add new features. Hoewer, tbh i'm not sure how i should even start to review this PR. Multiple things are being adjusted / features added, but the docs ( (I haven't looked to deeply, but i'm not a fan of adding+deleting an ip address where it's unclear if fritzflash is even responsible for configuring it in the first place.) idk, maybe @blocktrron has some advice |
allow to manually set ip address on failure
@maurerle I was not able to get this to work with the FB7520 on a Windows host. It was never able to complete the auto-discovery on LAN1 (there was never a link), LAN2, LAN3 but I think it did work once on LAN4. When I forced the autodiscovery by manually starting tftp and logging into the device (that effectively halts the boot), then I got the following error:
The launch parameters were: python3 fritzflash.py --image $env:USERPROFILE\Downloads\openwrt-23.05.4-ipq40xx-generic-avm_fritzbox-7530-initramfs-uImage.itb --sysupgrade $env:USERPROFILE\Downloads\avm-fritz-box-7520-sysupgrade.bin |
this feature adds support for more fritz devices:
this includes copying and writing the sysupgrade image if existing and doing all TFTP related extras for 7520/7530/1200.
And also executes the sysupgrade after booting initramfs if
--sysupgrade $IMAGENAME
is given.It is currently completely tested for all added devices and additionally: