Feat/reply with all via headers in sip responses #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 11, 2022 14:07
…tps://github.com/matteolc/sofia-sip into feat/reply-with-all-via-headers-in-SIP-responses
|
duplicate of #41 ? |
|
may I suggest to cleanup the patch from whitespaces fixes? makes hard spotting the real change ;) |
|
Sure, no problem I will remove the linter auto corrections. |
added 2 commits
July 11, 2022 22:57
|
Any update on this? Happy to make a new PR for this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some softswitches rely on Via header information in the 100 Trying response to be able to route calls internally (Sippy Softswitch for example). Without this information, softswitches sending calls to FreeSWITCH will fail to process the call because they are not able to match/route (internally) the INVITE with the 100 response received.
This behaviour may or may not be desirable and may or may not be SIP protocol complaint (it's internal spaghetti logic that could be avoided). However the end result is less interoperability in the wild.
The intent of this PR is to increase the interoperability of Sofia SIP/FreeSWITCH with a wider range of softswitches.