-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Boost to 1.87.0 #126
base: master
Are you sure you want to change the base?
Conversation
Test build https://github.com/o01eg/freeorion/actions/runs/12525177244/job/34936467814 have same error with MSVS project as previous version. |
e9dc88b
to
8ee7abc
Compare
8ee7abc
to
4cd2d3d
Compare
4cd2d3d
to
4277c16
Compare
If it works on MacOS, maybe also release it's as 15th SDK release? @Vezzra @geoffthemedio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can build the SDK, can build FO, but FO crashes on startup dumping this to the console:
$ ./FreeOrion
dyld[12619]: Library not loaded: '@rpath/libboost_random.dylib'
Referenced from: '/Volumes/FreeOrion/FreeOrion.app/Contents/SharedSupport/libboost_iostreams.dylib'
Reason: tried: '/Volumes/FreeOrion/FreeOrion.app/Contents/MacOS/../SharedSupport/libboost_random.dylib' (no such file), '/Volumes/FreeOrion/FreeOrion.app/Contents/MacOS/../SharedSupport/libboost_random.dylib' (no such file), '/Volumes/FreeOrion/FreeOrion.app/Contents/MacOS/../Frameworks/libboost_random.dylib' (no such file), '/Volumes/FreeOrion/FreeOrion.app/Contents/MacOS/../SharedSupport/libboost_random.dylib' (no such file), '/Volumes/FreeOrion/FreeOrion.app/Contents/MacOS/../Frameworks/libboost_random.dylib' (no such file), '/usr/local/lib/libboost_random.dylib' (no such file), '/usr/lib/libboost_random.dylib' (no such file)Library not loaded: '@rpath/libboost_graph.dylib'
Referenced from: '/Volumes/FreeOrion/FreeOrion.app/Contents/SharedSupport/libboost_python39.dylib'
Reason: tried: '/Volumes/FreeOrion/FreeOrion.app/Contents/MacOS/../SharedSupport/libboost_graph.dylib' (no such file), '/Volumes/FreeOrion/FreeOrion.app/Contents/MacOS/../SharedSupport/libboost_graph.dylib' (no such file), '/Volumes/FreeOrion/FreeOrion.app/Contents/MacOS/../Frameworks/libboost_graph.dylib' (no such file), '/Volumes/FreeOrion/FreeOrion.app/Contents/MacOS/../SharedSupport/libboost_graph.dylib' (no such file), '/Volumes/FreeOrion/FreeOrion.app/Contents/MacOS/../Frameworks/libboost_graph.dylib' (no such file), '/usr/local/lib/libboost_graph.dylib' (no such file), '/usr/lib/libboost_graph.dylib' (no such file)
Abort trap: 6
Once it works on Mac, sure, why not. |
I suppose it should be fixed with find_package(Boost ${MINIMUM_BOOST_VERSION}
COMPONENTS
...
random
graph
REQUIRED)
...
COMMAND
${CMAKE_COMMAND} -E copy_if_different "${Boost_RANDOM_LIBRARY}" "$<TARGET_FILE_DIR:freeorion>/../SharedSupport"
COMMAND
${CMAKE_COMMAND} -E copy_if_different "${Boost_GRAPH_LIBRARY}" "$<TARGET_FILE_DIR:freeorion>/../SharedSupport" in CMakeLists.txt in FreeOrion |
Ok, this is getting odd. When I add these lines to
However, FO still gets created correctly, but crashes on startup with this output to the console:
I'm confused 😕 |
@Vezzra I forgot to add those libraries as components. Here is fixed commit o01eg/freeorion@7b46e7b |
It looks like fixed now on MacOS too https://github.com/o01eg/freeorion/actions/runs/12537393113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I just tried to build commit e9bbf6da9b8dbbb8a8c81c770328e6034700a049 ("Add requirements for Boost.Random and Boost.Graph libraries") of the master branch on your repo, and that worked. I can build and run it.
On a second thought, I don't think building that commit pulled the updated SDK. Looks like it used the normal V14 of the SDK, so I probably need to build the SDK manually and check if it works with that commit in your master branch. |
Ok, sorry, obviously I got confused which commit to use to check/test which issue/PR. Looks like the commit I need to build to check this PR here is o01eg/freeorion@ddc5236 now, correct? I'll try that now. |
Oh, I often use |
No description provided.