Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soycode shippabletravis #23

Closed
wants to merge 10 commits into from
Closed

Soycode shippabletravis #23

wants to merge 10 commits into from

Conversation

agallant
Copy link

Fix #22 - however, the tests don't actually get all that far yet. Specifically it dies on:

TypeError: dest.write is not a function

However, I get the same issue locally, so it's likely not an issue with this ci code. I did a bit of perusing and it seems like it may have to do with Browserify (https://www.npmjs.com/package/gulp-browser is suggested as a possible fix). But having tests pass and having them run on ci are two separate problems, so I figured I'd make the pull request for discussion at least.

Thanks!

@agallant
Copy link
Author

Tests now kinda run on Shippable courtesy of f519731. They don't actually pass, but that may be a separate issue from this PR. Let me know your thoughts, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated test/build running
2 participants