Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change Left to Ended in sync with ERPNext #2542

Closed
wants to merge 1 commit into from

Conversation

mahsem
Copy link

@mahsem mahsem commented Dec 21, 2024

Change Left to Ended in sync with ERPNext
Backport to version-15

@mahsem mahsem requested a review from ruchamahabal as a code owner December 21, 2024 19:23
@mahsem mahsem marked this pull request as draft December 21, 2024 19:23
@mahsem mahsem changed the title fix: change Left to Ended in sync with ERPnext fix: change Left to Ended in sync with ERPNext Dec 21, 2024
Copy link
Member

@ruchamahabal ruchamahabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahsem
Copy link
Author

mahsem commented Dec 22, 2024

The employee status is "Left" not Ended https://github.com/frappe/erpnext/blob/56f561cdaa0689afbb14a8f6896e9a90dee91af9/erpnext/setup/doctype/employee/employee.json#L215

Ended is not acceptable as a status

@ruchamahabal I forget to set it as draft
Has to be approved in ERPNext first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants