-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Shift Assignment Schedule #2454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng shift schedule assignments
ruchamahabal
requested changes
Dec 16, 2024
hrms/patches/v15_0/migrate_shift_assignment_schedule_to_shift_schedule.py
Outdated
Show resolved
Hide resolved
hrms/patches/v15_0/migrate_shift_assignment_schedule_to_shift_schedule.py
Outdated
Show resolved
Hide resolved
- add breadcrumbs - format time properly for shifts
krantheman
added a commit
that referenced
this pull request
Dec 19, 2024
…2454 refactor: Shift Assignment Schedule (backport #2454)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Shift Assignment Schedule -> Shift Schedule + Shift Schedule Assignment
Details
Shift Assignment Schedule (Ref (Shift Creation -> Shift Assignment Schedule)) has been broken into two new doctypes to enable reusability of schedule definitions:-
Shift Schedule
Docs: https://docs.frappe.io/hr/shift-schedule
Shift Schedule Assignment
Docs: https://docs.frappe.io/hr/shift-schedule-assignment
The Shift Assignment Schedule doctype has been deprecated and removed. A patch has been included that migrates all existing Shift Assignment Schedules into Shift Schedules and Shift Schedule Assignments. The Shift Schedules thus created will be randomly named, but can be renamed thereafter.
Roster
Details
Shift Assignment Tool
Details
enabled = 1
) overlapping Shift Schedule Assignments are filtered out while rendering datatableDocs: https://docs.frappe.io/hr/shift-assignment-tool#22-assigning-shift-schedules
Shift Tools
Details
PS. I apologise for the bloated nature of this PR. Looking back, a lot of this could've been broken down into smaller PRs. 😅
PPS. Shift Schedule should probably be validated more, for overlap and other things. Might pick this up in the future some time.