fix: update status of reference documents #2380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -310,3 +313,9 @@ def update_full_and_final_statement_status(doc, method=None): | |||
| fnf = frappe.get_doc("Full and Final Statement", entry.reference_name) | |||
| fnf.db_set("status", status) | |||
| fnf.notify_update() | |||
|
|
|||
|
|
|||
| def update_status_of_reference_documents(doc, status="Paid"): | |||
There was a problem hiding this comment.
- We can encapsulate this function I think. No need to keep it outside the class
- Gratuity holds a "paid_amount" field. We should update that and call
gratuity.set_statusto update the status. If we just update the status,paid_amountfield will remain 0 - This should also mark gratuity as unpaid when FnF is cancelled. Current logic will change gratuity status to Cancelled I think.
Comment on lines
14
to
18
| frappe.db.set_value( | ||
| "Gratuity", | ||
| payable.reference_document, | ||
| {"status": self.status, "paid_amount": payable.amount}, | ||
| ) |
There was a problem hiding this comment.
set paid amount of gratuity doc and call set_status method so that the responsibility of setting the correct status is handled within gratuity itself
Also doesn't handle cancellation
|
replaced with: #2518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the status issue for gratuity payments. When a Full & Final Statement is marked as 'Paid,' the linked gratuity doc's status updates to 'Paid' too.