Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use db_set instead of set_value to trigger notification #44889

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

venkat102
Copy link
Contributor

Issue:
Notification is not triggering while updating the clearance date.
ref: 27780

Notification:
image

Before:

PE-Clearance-Date-Issue.mp4

After:

PE-Clearance-Date-Fix.mp4

Backport needed for v15

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 24, 2024
@ruthra-kumar ruthra-kumar self-assigned this Dec 24, 2024
@ruthra-kumar ruthra-kumar merged commit f0a34aa into frappe:develop Dec 24, 2024
14 checks passed
@ruthra-kumar
Copy link
Member

Using get_doc for every Payment Entry will cause performance issue. But there is no other way to trigger events I guess.

ruthra-kumar added a commit that referenced this pull request Dec 24, 2024
…-44889

refactor: use db_set instead of set_value to trigger notification (backport #44889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants