Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update item_tax_rate in backend #44884

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ljain112
Copy link
Contributor

@ljain112 ljain112 commented Dec 24, 2024

Issue: item_tax_rate is only set from the front end.
If the Item tax template is updated from the backend incorrect taxes are calculated.

Steps on how to replicate this issue

  • Create one item with only one item tax template
  • Create a transaction for this item. This should auto-fetch item tax template.
  • Unset item tax template from the item. Save

With unset, it doesn't unset item tax rate, causing incorrect final taxes.

Closes: #41081
Frappe Support Issue: https://support.frappe.io/app/hd-ticket/27836

backport-version-15-hotfix
backport-varsion-14-hotfix

@ljain112 ljain112 force-pushed the fix-item-tax-template branch from 165906b to de54c0b Compare December 24, 2024 09:45
@ruthra-kumar ruthra-kumar self-assigned this Dec 24, 2024
@ruthra-kumar
Copy link
Member

@ljain112

#44293 already moved the tax applying logic to server-side on develop branch. Better to make this change directly on v15

@ruthra-kumar ruthra-kumar changed the base branch from develop to version-15-hotfix December 24, 2024 11:07
@ruthra-kumar ruthra-kumar changed the base branch from version-15-hotfix to develop December 24, 2024 11:08
@ljain112
Copy link
Contributor Author

ljain112 commented Dec 24, 2024

@ljain112

#44293 already moved the tax applying logic to server-side on develop branch. Better to make this change directly on v15

@ruthra-kumar
The issue is still replicable in develop branch after enabling serve_side_reactivity because item_tax_template is updated in calculate_taxes_and_charges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Item Tax Rate
2 participants