feat: add Resolver#AddZone() method
#13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
force-pushed
the
feat/runtime-zone-updates
branch
from
89c7fce to
1887f3e
Compare
|
@ix64 @trois-six @foxcpp Any chance we can get a review on this or help by becoming repo maintainers? |
kd7lxl
reviewed
Nov 9, 2023
| func (r *Resolver) AddZone(name string, zone Zone) error { | ||
| r.zonesMutex.Lock() | ||
| defer r.zonesMutex.Unlock() | ||
|
|
There was a problem hiding this comment.
Would be nice if this canonicalized the name, since that's what the server tries to match during lookups.
Suggested change
| name = dns.CanonicalName(name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes